Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs]: Redirects with multilingual support have been fixed #SXA-7553 #1938

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Oct 2, 2024

Description / Motivation

This fix addresses the handling of redirects with support for non-default languages. The system now correctly redirects users to the appropriate pages based on the selected language(redirect), rather than defaulting to the primary language.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add unit test covering the case that is being fixed here?

Base automatically changed from bugfix/SXA-7554-redirects-double-parameters to dev October 8, 2024 09:51
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/SXA-7553-redirect-support-languages branch from 410e032 to 9703712 Compare October 8, 2024 12:06
@sc-ruslanmatkovskyi
Copy link
Collaborator Author

sc-ruslanmatkovskyi commented Oct 8, 2024

Looks good! Can we add unit test covering the case that is being fixed here?

There is such unit test in file. I've fixed tests and redirects)

Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yavorsk yavorsk merged commit 5d7a2d3 into dev Oct 9, 2024
1 check passed
@yavorsk yavorsk deleted the bugfix/SXA-7553-redirect-support-languages branch October 9, 2024 09:11
art-alexeyenko pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants